Discussion:
signal.in.h patch for DragonFly
(too old to reply)
Thomas Klausner
2017-03-15 13:58:26 UTC
Permalink
Raw Message
Hi!

When sending a patch to guile, they told me that the file comes from
gnulib and I should file the bug report there, so here it is.

The attached patch adds DragonFly support to lib/signal.in.h, please apply it.

Thanks,
Thomas
Bruno Haible
2017-03-15 16:10:31 UTC
Permalink
Raw Message
Hi,
Post by Thomas Klausner
The attached patch adds DragonFly support to lib/signal.in.h, please apply it.
The comment says that this include of <pthread.h> is there to make sure that
<signal.h> declares pthread_sigmask.

But on DragonFly (I checked versions 3.8, 4.6, and 4.8.0-RC), pthread_sigmask
is already declared in <signal.h>, not in <pthread.h>.

So what is the point of the proposed patch? What does it improve/correct/fix?

Bruno
Thomas Klausner
2017-03-15 16:34:03 UTC
Permalink
Raw Message
Hi!
Post by Bruno Haible
Post by Thomas Klausner
The attached patch adds DragonFly support to lib/signal.in.h, please apply it.
The comment says that this include of <pthread.h> is there to make sure that
<signal.h> declares pthread_sigmask.
But on DragonFly (I checked versions 3.8, 4.6, and 4.8.0-RC), pthread_sigmask
is already declared in <signal.h>, not in <pthread.h>.
So what is the point of the proposed patch? What does it improve/correct/fix?
Thanks for the analysis. I trusted the DragonFly person who added the
patch to have a point, but I trust your analysis more, so please
disregard the patch. I'll come back about it in case there is a reason
after all.

Thanks,
Thomas

Loading...