Discussion:
license change of futimens was incomplete
(too old to reply)
Bruno Haible
2016-10-15 14:14:18 UTC
Permalink
Raw Message
When I run

$ ./gnulib-tool --create-testdir --with-tests --dir=/tmp/testdir1

I get these warnings, among others:

gnulib-tool: warning: module futimens depends on a module with an incompatible license: gettime
gnulib-tool: warning: module futimens depends on a module with an incompatible license: timespec
gnulib-tool: warning: module futimens depends on a module with an incompatible license: utimens

It is a consequence of a license change on 2011-05-05
http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00183.html

Can we change the license of the modules 'gettime', 'timespec', 'utimens'
to 'LGPL'?

Agreements are needed:
- For gettime: from Paul, Jim.
- For timespec: from Jim, Paul, Pádraig.
- For utimens: from Paul, Eric, Jim, Bruno, Aurelien Jarno.

You hereby have my agreement (since all these modules are suitable for use
in libraries).

Paul, Jim, Eric, Pádraig, Aurelien, can we have yours?


diff --git a/modules/gettime b/modules/gettime
index e1efe76..fcbb644 100644
--- a/modules/gettime
+++ b/modules/gettime
@@ -25,7 +25,7 @@ Link:
$(LIB_CLOCK_GETTIME)

License:
-GPL
+LGPL

Maintainer:
Paul Eggert, Jim Meyering
diff --git a/modules/timespec b/modules/timespec
index 176022c..d18d146 100644
--- a/modules/timespec
+++ b/modules/timespec
@@ -20,7 +20,7 @@ Include:
"timespec.h"

License:
-GPL
+LGPL

Maintainer:
Paul Eggert and Jim Meyering
diff --git a/modules/utimens b/modules/utimens
index 8797774..f925034 100644
--- a/modules/utimens
+++ b/modules/utimens
@@ -34,7 +34,7 @@ Link:
$(LIB_CLOCK_GETTIME)

License:
-GPL
+LGPL

Maintainer:
Paul Eggert, Jim Meyering, Eric Blake

--
In memoriam Thomas Sankara <http://en.wikipedia.org/wiki/Thomas_Sankara>
Jim Meyering
2016-10-15 16:01:34 UTC
Permalink
Raw Message
Post by Bruno Haible
Can we change the license of the modules 'gettime', 'timespec', 'utimens'
to 'LGPL'?
Yes. Thanks for noticing/addressing.
Eric Blake
2016-10-15 16:30:32 UTC
Permalink
Raw Message
Post by Bruno Haible
Can we change the license of the modules 'gettime', 'timespec', 'utimens'
to 'LGPL'?
- For gettime: from Paul, Jim.
- For timespec: from Jim, Paul, Pádraig.
- For utimens: from Paul, Eric, Jim, Bruno, Aurelien Jarno.
You hereby have my agreement (since all these modules are suitable for use
in libraries).
Paul, Jim, Eric, Pádraig, Aurelien, can we have yours?
LGPL, or LGPLv2+?

I know we were reluctant to relicense openat and friends for a while,
because the fallback could abort (which is never safe for a library).
Is that still an issue for futimens?

But I'm okay with my contributions, whether to LGPL or even the looser
LGPLv2+.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Bruno Haible
2016-10-16 00:07:34 UTC
Permalink
Raw Message
Post by Eric Blake
LGPL, or LGPLv2+?
LGPL. No one has asked for an LGPLv2+ copy of the 'futimens' nor 'utimens'
modules.
Post by Eric Blake
I know we were reluctant to relicense openat and friends for a while,
because the fallback could abort (which is never safe for a library).
I disagree: It is OK for a library to call 'abort ()'. abort () means that
the developer made a mistake, and that mistake needs to be reported to them.
abort () is the best means to do that, because it provides a stack trace
and even, on some platforms (those with 'apport'), sends a core dump to
the developer.

In gnulib the following LGPL modules contain calls to abort ():

acl-permissions
areadlink
array-list
array-oset
astrxfrm
avltree-list
avltree-oset
avltreehash-list
carray-list
euidaccess
fcntl
fd-hook
fma
fmod
freadahead
freadptr
freadseek
fseterr
fts
hash
i-ring
iconv
imaxdiv
linkedhash-list
mbrtowc
mbscasestr
mbssep
mbsstr
obstack
perror
popen
random
rbtree-list
rbtree-oset
rbtreehash-list
regex
rename
rint
setlocale
sigaction
sigprocmask
strerror
strerror_r-posix
striconv
striconveh
strtod
sublist
tempname
tsearch
uname
vasnprintf
version-etc
wctob
xstrtol

And glibc contains tons of abort () calls as well.
Post by Eric Blake
But I'm okay with my contributions, whether to LGPL or even the looser
LGPLv2+.
Thanks.

Bruno
--
In memoriam Marie Antoinette <http://en.wikipedia.org/wiki/Marie_Antoinette>
Pádraig Brady
2016-10-15 22:34:26 UTC
Permalink
Raw Message
Post by Bruno Haible
When I run
$ ./gnulib-tool --create-testdir --with-tests --dir=/tmp/testdir1
gnulib-tool: warning: module futimens depends on a module with an incompatible license: gettime
gnulib-tool: warning: module futimens depends on a module with an incompatible license: timespec
gnulib-tool: warning: module futimens depends on a module with an incompatible license: utimens
It is a consequence of a license change on 2011-05-05
http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00183.html
Can we change the license of the modules 'gettime', 'timespec', 'utimens'
to 'LGPL'?
- For gettime: from Paul, Jim.
- For timespec: from Jim, Paul, Pádraig.
- For utimens: from Paul, Eric, Jim, Bruno, Aurelien Jarno.
You hereby have my agreement (since all these modules are suitable for use
in libraries).
Paul, Jim, Eric, Pádraig, Aurelien, can we have yours?
ack.

thanks
Aurelien Jarno
2016-10-16 00:30:19 UTC
Permalink
Raw Message
Post by Bruno Haible
When I run
$ ./gnulib-tool --create-testdir --with-tests --dir=/tmp/testdir1
gnulib-tool: warning: module futimens depends on a module with an incompatible license: gettime
gnulib-tool: warning: module futimens depends on a module with an incompatible license: timespec
gnulib-tool: warning: module futimens depends on a module with an incompatible license: utimens
It is a consequence of a license change on 2011-05-05
http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00183.html
Can we change the license of the modules 'gettime', 'timespec', 'utimens'
to 'LGPL'?
- For gettime: from Paul, Jim.
- For timespec: from Jim, Paul, Pádraig.
- For utimens: from Paul, Eric, Jim, Bruno, Aurelien Jarno.
You hereby have my agreement (since all these modules are suitable for use
in libraries).
Paul, Jim, Eric, Pádraig, Aurelien, can we have yours?
I actually only added a single line of code :-). Anyway you have my
agreement to relicense it to LGPL.

Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
***@aurel32.net http://www.aurel32.net
Bruno Haible
2016-10-16 10:33:31 UTC
Permalink
Raw Message
Post by Aurelien Jarno
I actually only added a single line of code :-). Anyway you have my
agreement to relicense it to LGPL.
Well, it was 1 line of code with a 7-lines git commit entry :)

Thanks for all the approvals, I've pushed this change.

Bruno
--
In memoriam Thet Win Aung <http://en.wikipedia.org/wiki/Thet_Win_Aung>
Paul Eggert
2016-10-16 04:22:06 UTC
Permalink
Raw Message
Post by Bruno Haible
- For gettime: from Paul, Jim.
- For timespec: from Jim, Paul, Pádraig.
- For utimens: from Paul, Eric, Jim, Bruno, Aurelien Jarno.
OK with me.
Loading...