Discussion:
[Emacs-diffs] master updated (3c586e1 -> 0bbf00c)
(too old to reply)
Paul Eggert
2016-09-16 07:58:04 UTC
Permalink
Raw Message
I don't like the idea that Gnulib should dictate whether Emacs uses
this MinGW feature or not. If there are good reasons for that (can
you tell what they are?),
Setting __USE_MINGW_ANSI_STDIO is part of Gnulib's usual desire to support a
GNU-like environment even on non-GNU hosts.

Formerly, defining __USE_MINGW_ANSI_STDIO to 1 was done by
AC_USE_SYSTEM_EXTENSIONS (defined in m4/extensions.m4), but as this is not
really a system extension I recently moved that definition to gl_STDIO_H
(defined in m4/stdio_h.m4). When I did this I used a simple AC_DEFINE to 1, as I
assumed this would suffice. Evidently it does not work for Emacs, so I just now
adjusted the moved version in Emacs master (and in Gnulib) to look more like the
original, as per the attached Emacs patch.
Eli Zaretskii
2016-09-16 08:32:52 UTC
Permalink
Raw Message
Date: Fri, 16 Sep 2016 00:58:04 -0700
I don't like the idea that Gnulib should dictate whether Emacs uses
this MinGW feature or not. If there are good reasons for that (can
you tell what they are?),
Setting __USE_MINGW_ANSI_STDIO is part of Gnulib's usual desire to support a
GNU-like environment even on non-GNU hosts.
Ah, okay. My interpretation of that is that we don't need to define
that symbol, as long as there's no specific reason why we should do
so. When we decide to use it, it should be defined in nt/inc/ms-w32.h
before _mingw.h is included.
Formerly, defining __USE_MINGW_ANSI_STDIO to 1 was done by
AC_USE_SYSTEM_EXTENSIONS (defined in m4/extensions.m4), but as this is not
really a system extension I recently moved that definition to gl_STDIO_H
(defined in m4/stdio_h.m4). When I did this I used a simple AC_DEFINE to 1, as I
assumed this would suffice. Evidently it does not work for Emacs, so I just now
adjusted the moved version in Emacs master (and in Gnulib) to look more like the
original, as per the attached Emacs patch.
Thanks, the warnings are gone.

Loading...