Discussion:
suggested improvements to parse-datetime's debug messages ('date --debug')
(too old to reply)
Assaf Gordon
2017-01-02 02:25:36 UTC
Permalink
Raw Message
Hello,

Attached are four small bug fixes and two additions to the debug messages in parse-datetime.y (used in 'date --debug').
The commit message for each commit gives a detail example of how/when it is used.
There are no changes to the parsing, only to the debug messages.

Comments and suggestions welcomed,

regards,
-assaf
Pádraig Brady
2017-01-02 12:25:07 UTC
Permalink
Raw Message
Post by Assaf Gordon
Hello,
Attached are four small bug fixes and two additions to the debug messages in parse-datetime.y (used in 'date --debug').
The commit message for each commit gives a detail example of how/when it is used.
There are no changes to the parsing, only to the debug messages.
Comments and suggestions welcomed,
Excellent. Changes look good to me modulo a couple of typos:

/timezome/timezone/
/arithmentics/arithmetic/

Please push.
I presume there will be a corresponding coreutils commit
to adjust/add test cases.

thanks!
Pádraig.
Assaf Gordon
2017-01-05 05:38:20 UTC
Permalink
Raw Message
Post by Pádraig Brady
Post by Assaf Gordon
Hello,
Attached are four small bug fixes and two additions to the debug messages in parse-datetime.y (used in 'date --debug').
Please push.
Thank you for the review, pushed.
Post by Pádraig Brady
I presume there will be a corresponding coreutils commit
to adjust/add test cases.
Yes, will send it soon.

Thanks!
- assaf

Loading...