Discussion:
gnulib-tool uses deprecated ACLOCAL_AMFLAGS
(too old to reply)
Michael Stapelberg
2016-11-07 07:45:07 UTC
Permalink
Raw Message
ACLOCAL_AMFLAGS was deprecated in 2012 according to
https://lists.gnu.org/archive/html/automake-patches/2012-12/msg00079.html

Yet, the gnulib git repository contains a couple of references to it (as of
commit 2f8b355aeacb448d13bab9cb3cdaaeea649a4664):

$ grep -r ACLOCAL_AMFLAGS
gnulib-tool: echo "ACLOCAL_AMFLAGS = -I ${testsbase_inverse}/${m4base}"
gnulib-tool: func_note_Makefile_am_edit "" ACLOCAL_AMFLAGS "-I ${m4base}"
gnulib-tool: echo "ACLOCAL_AMFLAGS = -I $m4base"
gnulib-tool: aclocal_amflags=`sed -n -e 's/^ACLOCAL_AMFLAGS[
]*=\(.*\)$/\1/p'
"$destdir"/Makefile.am`
doc/gnulib-tool.texi: - mention "-I m4" in ACLOCAL_AMFLAGS in Makefile.am,
doc/gnulib-tool.texi:@file{gnulib-comp.m4}. Use the @code{ACLOCAL_AMFLAGS}
specifier in
doc/gnulib-tool.texi:ACLOCAL_AMFLAGS = -I m4
ChangeLog: ACLOCAL_AMFLAGS parsing state machine.

I originally intended to just send a patch to update the documentation, but
now I’m not certain if that in itself is a good idea without also updating
the code, and I don’t have the time to wrestle with large shell scripts
currently :).
--
Best regards,
Michael
Bruno Haible
2016-11-07 16:40:06 UTC
Permalink
Raw Message
Hi,
Post by Michael Stapelberg
ACLOCAL_AMFLAGS was deprecated in 2012 according to
https://lists.gnu.org/archive/html/automake-patches/2012-12/msg00079.html
What should the replacement be? The Automake NEWS from git (unreleased) says:

- Use of the special makefile variable 'ACLOCAL_AMFLAGS' is deprecated.
To specify locations of extra m4 files, the 'AC_CONFIG_MACRO_DIR' or
'AC_CONFIG_MACRO_DIRS' (the latter introduced with autoconf 2.70)
should be used instead.

The Autoconf NEWS from git (unreleased) goes into more details:

- AC_CONFIG_MACRO_DIRS
New macro, used to declare multiple directories when looking for
local M4 macros. This macro overcomes some of the shortfalls in the
older AC_CONFIG_MACRO_DIR, which could only be used once; ...

The result of gnulib-tool most often contains a directory m4 files which
is not the only one for a given package. Therefore the recommended replacement
should be to use AC_CONFIG_MACRO_DIRS.

But AC_CONFIG_MACRO_DIRS is not yet released.
Post by Michael Stapelberg
Yet, the gnulib git repository contains a couple of references to it (as of
$ grep -r ACLOCAL_AMFLAGS
gnulib-tool: echo "ACLOCAL_AMFLAGS = -I ${testsbase_inverse}/${m4base}"
gnulib-tool: func_note_Makefile_am_edit "" ACLOCAL_AMFLAGS "-I ${m4base}"
gnulib-tool: echo "ACLOCAL_AMFLAGS = -I $m4base"
gnulib-tool: aclocal_amflags=`sed -n -e 's/^ACLOCAL_AMFLAGS[
]*=\(.*\)$/\1/p'
"$destdir"/Makefile.am`
doc/gnulib-tool.texi: - mention "-I m4" in ACLOCAL_AMFLAGS in Makefile.am,
specifier in
doc/gnulib-tool.texi:ACLOCAL_AMFLAGS = -I m4
ChangeLog: ACLOCAL_AMFLAGS parsing state machine.
I originally intended to just send a patch to update the documentation, but
now I’m not certain if that in itself is a good idea without also updating
the code, and I don’t have the time to wrestle with large shell scripts
currently :).
This is all welcome, but only after Autoconf 2.70 is released.

Bruno
Eric Blake
2016-11-07 16:47:08 UTC
Permalink
Raw Message
Post by Bruno Haible
Post by Michael Stapelberg
I originally intended to just send a patch to update the documentation, but
now I’m not certain if that in itself is a good idea without also updating
the code, and I don’t have the time to wrestle with large shell scripts
currently :).
This is all welcome, but only after Autoconf 2.70 is released.
Which I'm working on; hopefully to happen this month.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Loading...