Discussion:
[PATCH] test-faccessat.c: unlink temp file to avoid subsequent test failure
(too old to reply)
Pádraig Brady
2017-12-11 01:48:18 UTC
Permalink
Raw Message
* tests/test-faccessat.c: Remove the file to avoid failure
to open the file on subsequent runs due to being created
with no permissions.
---
ChangeLog | 7 +++++++
tests/test-faccessat.c | 1 +
2 files changed, 8 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 96ba6d0..ccb526b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2017-12-10 Pádraig Brady <***@draigBrady.com>
+
+ test-faccessat.c: unlink temp file to avoid subsequent test failure
+ * tests/test-faccessat.c: Remove the file to avoid failure
+ to open the file on subsequent runs due to being created
+ with no permissions.
+
2017-12-10 Bruno Haible <***@clisp.org>

doc: New sect. "Modifying the build rules of a Gnulib import directory".
diff --git a/tests/test-faccessat.c b/tests/test-faccessat.c
index fe1db41..e880fae 100644
--- a/tests/test-faccessat.c
+++ b/tests/test-faccessat.c
@@ -69,6 +69,7 @@ main (void)
unlink (BASE "link3");
}
unlink (BASE "link1");
+ unlink (BASE "file");

return 0;
}
--
2.9.3
Pádraig Brady
2017-12-11 02:05:13 UTC
Permalink
Raw Message
On 10/12/17 17:48, Pádraig Brady wrote:
> * tests/test-faccessat.c: Remove the file to avoid failure
> to open the file on subsequent runs due to being created
> with no permissions.
> ---
> ChangeLog | 7 +++++++
> tests/test-faccessat.c | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/ChangeLog b/ChangeLog
> index 96ba6d0..ccb526b 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,10 @@
> +2017-12-10 Pádraig Brady <***@draigBrady.com>
> +
> + test-faccessat.c: unlink temp file to avoid subsequent test failure
> + * tests/test-faccessat.c: Remove the file to avoid failure
> + to open the file on subsequent runs due to being created
> + with no permissions.
> +
> 2017-12-10 Bruno Haible <***@clisp.org>
>
> doc: New sect. "Modifying the build rules of a Gnulib import directory".
> diff --git a/tests/test-faccessat.c b/tests/test-faccessat.c
> index fe1db41..e880fae 100644
> --- a/tests/test-faccessat.c
> +++ b/tests/test-faccessat.c
> @@ -69,6 +69,7 @@ main (void)
> unlink (BASE "link3");
> }
> unlink (BASE "link1");
> + unlink (BASE "file");
>
> return 0;
> }

I pushed a further tweak to be more defensive
and try to unlink() the file before creating it
Loading...